Issue 875773002: Oilpan: disable stack depth assert with ASan enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 875773002: Oilpan: disable stack depth assert with ASan enabled. (Closed)

Created:
5 years, 11 months ago by sof

Modified:
5 years, 11 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: disable stack depth assert with ASan enabled. The assert to catch out needlessly deep GC marking recursion assumes a lower per-stack frame overhead than what ASan-compiled code provides. Hence, disable this stack depth assert when ASan is enabled so as to avoid triggering it against much lower stack depths. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188947

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	Source/platform/heap/Visitor.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875773002/1

5 years, 11 months ago (2015-01-26 07:49:25 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-26 09:12:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188947

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages