Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 875773002: Oilpan: disable stack depth assert with ASan enabled. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: disable stack depth assert with ASan enabled. The assert to catch out needlessly deep GC marking recursion assumes a lower per-stack frame overhead than what ASan-compiled code provides. Hence, disable this stack depth assert when ASan is enabled so as to avoid triggering it against much lower stack depths. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/platform/heap/Visitor.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 11 months ago (2015-01-26 07:41:15 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-26 07:44:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875773002/1
5 years, 11 months ago (2015-01-26 07:49:25 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 09:12:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188947

Powered by Google App Engine
This is Rietveld 408576698