Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: Source/platform/heap/Visitor.h

Issue 875773002: Oilpan: disable stack depth assert with ASan enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Visitor.h
diff --git a/Source/platform/heap/Visitor.h b/Source/platform/heap/Visitor.h
index 28d92bf424abfdf12e5a8bb6aff36bdb137d79b8..969d25f78d2edadbbba48c3e45c3fa73c218e77f 100644
--- a/Source/platform/heap/Visitor.h
+++ b/Source/platform/heap/Visitor.h
@@ -765,10 +765,17 @@ public:
// Assert against deep stacks so as to flush them out,
// but test and appropriately handle them should they occur
// in release builds.
+ //
+ // ASan adds extra stack usage, so disable the assert when it is
+ // enabled so as to avoid testing against a much lower & too low,
+ // stack depth threshold.
+ //
// FIXME: visitor->isMarked(t) exception is to allow empty trace()
// calls from HashTable weak processing. Remove the condition once
// it is refactored.
+#if !defined(ADDRESS_SANITIZER)
ASSERT(visitor->canTraceEagerly() || visitor->isMarked(t));
+#endif
if (LIKELY(visitor->canTraceEagerly())) {
if (visitor->ensureMarked(t)) {
TraceTrait<T>::trace(visitor, const_cast<T*>(t));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698