Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: sky/framework/embedder.sky

Issue 875713003: Upgrade Sky's use of the JS bindings (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/framework/shell.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/embedder.sky
diff --git a/sky/framework/embedder.sky b/sky/framework/embedder.sky
index 742b7fa2ba561882d81bbfd8ed7a8b31634f3060..7369582ec18cefd35c0778fbc5dafec6fb11d291 100644
--- a/sky/framework/embedder.sky
+++ b/sky/framework/embedder.sky
@@ -1,8 +1,8 @@
-<import src="shell.sky" as="shell" />
+<import src="/gen/mojo/public/sky/connection.sky" as="connection" />
<script>
-function connectToEmbedderService(service, client) {
- var handle = internals.connectToEmbedderService(service.name);
- return shell.wrapHandle(handle, service, client);
+function connectToEmbedderService(service/*, client*/) {
abarth-chromium 2015/01/28 19:23:17 Can we just delete |client| instead of commenting
hansmuller1 2015/01/28 19:27:05 Oops, sorry about that.
+ var handle = internals.connectToEmbedderService(service.name);
+ return connection.bindHandleToProxy(handle, service);
}
module.exports = {
« no previous file with comments | « no previous file | sky/framework/shell.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698