sky/framework/embedder.sky - Issue 875713003: Upgrade Sky's use of the JS bindings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/framework/embedder.sky

Issue 875713003: Upgrade Sky's use of the JS bindings (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <import src="shell.sky" as="shell" />	1 <import src="/gen/mojo/public/sky/connection.sky" as="connection" />

2 <script>	2 <script>

3 function connectToEmbedderService(service, client) {	3 function connectToEmbedderService(service/, client/) {
	abarth-chromium 2015/01/28 19:23:17 Can we just delete \|client\| instead of commenting Can we just delete \|client\| instead of commenting it out? hansmuller1 2015/01/28 19:27:05 Oops, sorry about that. Show quoted text On 2015/01/28 19:23:17, abarth wrote: > Can we just delete \|client\| instead of commenting it out? Oops, sorry about that.
4 var handle = internals.connectToEmbedderService(service.name);	4 var handle = internals.connectToEmbedderService(service.name);

5 return shell.wrapHandle(handle, service, client);	5 return connection.bindHandleToProxy(handle, service);

6 }	6 }

7	7

8 module.exports = {	8 module.exports = {

9 connectToEmbedderService: connectToEmbedderService,	9 connectToEmbedderService: connectToEmbedderService,

10 };	10 };

11 </script>	11 </script>

OLD	NEW

« no previous file with comments | « no previous file | sky/framework/shell.sky » ('j') | no next file with comments »