Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 875713003: Upgrade Sky's use of the JS bindings (Closed)

Created:
5 years, 10 months ago by hansmuller
Modified:
5 years, 10 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M sky/framework/embedder.sky View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sky/framework/shell.sky View 1 chunk +1 line, -7 lines 0 comments Download
M sky/framework/xmlhttprequest.sky View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hansmuller1
PTAL
5 years, 10 months ago (2015-01-28 19:13:40 UTC) #3
abarth-chromium
lgtm https://codereview.chromium.org/875713003/diff/1/sky/framework/embedder.sky File sky/framework/embedder.sky (right): https://codereview.chromium.org/875713003/diff/1/sky/framework/embedder.sky#newcode3 sky/framework/embedder.sky:3: function connectToEmbedderService(service/*, client*/) { Can we just delete ...
5 years, 10 months ago (2015-01-28 19:23:18 UTC) #4
hansmuller1
https://codereview.chromium.org/875713003/diff/1/sky/framework/embedder.sky File sky/framework/embedder.sky (right): https://codereview.chromium.org/875713003/diff/1/sky/framework/embedder.sky#newcode3 sky/framework/embedder.sky:3: function connectToEmbedderService(service/*, client*/) { On 2015/01/28 19:23:17, abarth wrote: ...
5 years, 10 months ago (2015-01-28 19:27:05 UTC) #5
hansmuller
5 years, 10 months ago (2015-01-28 19:27:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
898dd9e4f780a5affaa8696dbc637a83c22ba440 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698