Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 875283003: Make all callers of scheduleAnimation() use scheduleVisualUpdate(). (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make all callers of scheduleAnimation() use scheduleVisualUpdate(). The only scheduleAnimation() methods left are going through the layers of client interfaces. I'll rename and remove those next. This is working towards making requestAnimationFrame() not cause a full repaint and also making it more clear to callers that scheduling a frame causes a raster. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3d67f42464303ec7b2932904122c118bd95b93c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -53 lines) Patch
M sky/engine/core/animation/AnimationTimeline.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/animation/DocumentAnimations.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/engine/core/animation/PendingAnimations.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/ScriptedAnimationController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/page/AutoscrollController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/page/PageAnimator.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/platform/scroll/ScrollAnimator.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-26 23:37:24 UTC) #2
esprehn
5 years, 11 months ago (2015-01-26 23:42:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d67f42464303ec7b2932904122c118bd95b93c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698