sky/engine/core/animation/DocumentAnimations.cpp - Issue 875283003: Make all callers of scheduleAnimation() use scheduleVisualUpdate().

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/engine/core/animation/DocumentAnimations.cpp

Issue 875283003: Make all callers of scheduleAnimation() use scheduleVisualUpdate(). (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « sky/engine/core/animation/AnimationTimeline.cpp ('k') | sky/engine/core/animation/PendingAnimations.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66	66

67 bool DocumentAnimations::needsOutdatedAnimationPlayerUpdate(const Document& docu ment)	67 bool DocumentAnimations::needsOutdatedAnimationPlayerUpdate(const Document& docu ment)

68 {	68 {

69 return document.timeline().hasOutdatedAnimationPlayer();	69 return document.timeline().hasOutdatedAnimationPlayer();

70 }	70 }

71	71

72 // FIXME: Rename to updateCompositorAnimations	72 // FIXME: Rename to updateCompositorAnimations

73 void DocumentAnimations::startPendingAnimations(Document& document)	73 void DocumentAnimations::startPendingAnimations(Document& document)

74 {	74 {

75 ASSERT(document.lifecycle().state() == DocumentLifecycle::StyleAndLayoutClea n);	75 ASSERT(document.lifecycle().state() == DocumentLifecycle::StyleAndLayoutClea n);

76 if (document.pendingAnimations().update()) {	76 if (document.pendingAnimations().update())

77 ASSERT(document.view());	77 document.scheduleVisualUpdate();

78 document.view()->scheduleAnimation();

79 }

80 }	78 }

81	79

82 } // namespace blink	80 } // namespace blink

OLD	NEW