Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 875043005: Fix Windows build warning (Closed)

Created:
5 years, 11 months ago by JF
Modified:
5 years, 10 months ago
Reviewers:
kschimpf, Karl
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Windows build warning This CL: https://codereview.chromium.org/863093002 Is trying to turn on -Werror, and Windows' compiler thinks control reaches end of non-void function, but it's wrong because all cases are handled. Note our disagreement using llvm_unreachable. TBR= kschimpf@chromium.org BUG= none Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=3e9946d10b7ea0851100b4bade81ac8f67c95a61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
JF
5 years, 11 months ago (2015-01-27 04:34:29 UTC) #1
JF
Committed patchset #1 (id:1) manually as 3e9946d10b7ea0851100b4bade81ac8f67c95a61 (presubmit successful).
5 years, 11 months ago (2015-01-27 04:34:59 UTC) #2
Karl
5 years, 10 months ago (2015-01-27 15:23:30 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698