Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 874963002: Before conversion to AXTableCell, isTableCell() should be called. (Closed)

Created:
5 years, 11 months ago by k.czech
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, inferno
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Before conversion to AXTableCell, isTableCell() should be called. Asan reported ASSERTION FAILED: !object || (object->isTableCell()) in headerObjectsForColumn. Before conversion to AXTableCell, isTableCell() should be called on AXObject. BUG=451773 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189026

Patch Set 1 #

Patch Set 2 : Rebaseline changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/accessibility/AXTableColumn.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
k.czech
Mac's ASAN reported ASSERTION FAILED: !object || (object->isTableCell()). I'm not able to open a test ...
5 years, 11 months ago (2015-01-26 11:59:39 UTC) #2
dmazzoni
lgtm
5 years, 11 months ago (2015-01-26 22:54:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874963002/1
5 years, 11 months ago (2015-01-26 22:55:00 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/modules/accessibility/AXTableColumn.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 11 months ago (2015-01-26 22:55:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874963002/20001
5 years, 11 months ago (2015-01-27 10:30:29 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 11:50:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189026

Powered by Google App Engine
This is Rietveld 408576698