Source/modules/accessibility/AXTableColumn.cpp - Issue 874963002: Before conversion to AXTableCell, isTableCell() should be called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXTableColumn.cpp

Issue 874963002: Before conversion to AXTableCell, isTableCell() should be called. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebaseline changes Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXTableColumn.cpp

diff --git a/Source/modules/accessibility/AXTableColumn.cpp b/Source/modules/accessibility/AXTableColumn.cpp

index ee07161faaadc1bc3e492a4bdc99167a996e5d3d..aec01b26afaf5f8c9d650eb3077c88066c88ef92 100644

--- a/Source/modules/accessibility/AXTableColumn.cpp

+++ b/Source/modules/accessibility/AXTableColumn.cpp

@@ -90,7 +90,7 @@ void AXTableColumn::headerObjectsForColumn(AccessibilityChildrenVector& headers)

continue;

AXObject* cell = axObjectCache()->getOrCreate(layoutCell->node());

- if (!cell)

+ if (!cell || !cell->isTableCell())

continue;

if (toAXTableCell(cell)->scanToDecideHeaderRole() == ColumnHeaderRole)

« no previous file with comments | « no previous file | no next file » | no next file with comments »