Issue 874743007: Revert of Linux: Enable ODR violation detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 874743007: Revert of Linux: Enable ODR violation detection. (Closed)

Created:
5 years, 10 months ago by Lei Zhang

Modified:
5 years, 10 months ago

Reviewers:
Nico, Ilya Sherman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Linux: Enable ODR violation detection. (patchset #6 id:100001 of https://codereview.chromium.org/899403003/) Reason for revert: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/55780 found more ODR violations in libjingle. Original issue's description: > Linux: Enable ODR violation detection. > > BUG=449754 > > Committed: https://crrev.com/e86588abd0f3b65777d8bc679747eeb6bbdf21f8 > Cr-Commit-Position: refs/heads/master@{#315906} TBR=thakis@chromium.org,isherman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449754 Committed: https://crrev.com/e285e7bb174c9019b680f2b4f7831e107d5792eb Cr-Commit-Position: refs/heads/master@{#315916}

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -25 lines)			Patch
M	build/common.gypi	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	build/config/compiler/BUILD.gn	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	third_party/libphonenumber/BUILD.gn	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	third_party/libphonenumber/libphonenumber.gyp	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

Lei Zhang

Created Revert of Linux: Enable ODR violation detection.

5 years, 10 months ago (2015-02-12 02:48:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874743007/1

5 years, 10 months ago (2015-02-12 02:49:10 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-12 02:51:10 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e285e7bb174c9019b680f2b4f7831e107d5792eb
Cr-Commit-Position: refs/heads/master@{#315916}