Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: build/common.gypi

Issue 874743007: Revert of Linux: Enable ODR violation detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4365 matching lines...) Expand 10 before | Expand all | Expand 10 after
4376 # Experimentation found that using four linking threads 4376 # Experimentation found that using four linking threads
4377 # saved ~20% of link time. 4377 # saved ~20% of link time.
4378 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36 4378 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36
4379 # Only apply this to the target linker, since the host 4379 # Only apply this to the target linker, since the host
4380 # linker might not be gold, but isn't used much anyway. 4380 # linker might not be gold, but isn't used much anyway.
4381 # TODO(raymes): Disable threading because gold is frequently 4381 # TODO(raymes): Disable threading because gold is frequently
4382 # crashing on the bots: crbug.com/161942. 4382 # crashing on the bots: crbug.com/161942.
4383 # '-Wl,--threads', 4383 # '-Wl,--threads',
4384 # '-Wl,--thread-count=4', 4384 # '-Wl,--thread-count=4',
4385 ], 4385 ],
4386 'conditions': [
4387 # TODO(thestig): Enable this for CrOS and Sanitizers.
4388 [ 'chromeos==0 and asan==0 and lsan==0 and tsan==0 and msan==0 and ubsan==0 and ubsan_vptr==0', {
4389 'ldflags': [
4390 '-Wl,--detect-odr-violations',
4391 ],
4392 }],
4393 ],
4394 }], 4386 }],
4395 ], 4387 ],
4396 'conditions': [ 4388 'conditions': [
4397 ['release_valgrind_build==0 and order_profiling==0', { 4389 ['release_valgrind_build==0 and order_profiling==0', {
4398 'target_conditions': [ 4390 'target_conditions': [
4399 ['_toolset=="target"', { 4391 ['_toolset=="target"', {
4400 'ldflags': [ 4392 'ldflags': [
4401 '-Wl,--icf=safe', 4393 '-Wl,--icf=safe',
4402 ], 4394 ],
4403 }], 4395 }],
(...skipping 1468 matching lines...) Expand 10 before | Expand all | Expand 10 after
5872 # settings in target dicts. SYMROOT is a special case, because many other 5864 # settings in target dicts. SYMROOT is a special case, because many other
5873 # Xcode variables depend on it, including variables such as 5865 # Xcode variables depend on it, including variables such as
5874 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5866 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5875 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5867 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5876 # files to appear (when present) in the UI as actual files and not red 5868 # files to appear (when present) in the UI as actual files and not red
5877 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5869 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5878 # and therefore SYMROOT, needs to be set at the project level. 5870 # and therefore SYMROOT, needs to be set at the project level.
5879 'SYMROOT': '<(DEPTH)/xcodebuild', 5871 'SYMROOT': '<(DEPTH)/xcodebuild',
5880 }, 5872 },
5881 } 5873 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698