Fix host installation on i686 Linux.

Fix host installation on i686 Linux.

HostInstaller uses navigator.platform to figure out which package
needs to be downloaded to install host on the curren machine. Problem
was that on linux navigator.platform may be set to "Linux i686" and
HostIntaller wasn't handling it properly. With this change:
  1. "Linux i686" is properly recognized as ia32 Linux.
  2. Unsupported platforms are properly handled by disabling the
     "Share" button.

BUG=442943
Committed: https://crrev.com/3cf7e0eb1dab5c8f6399f287adaf4f5b88d352da
Cr-Commit-Position: refs/heads/master@{#313030}

[Sergey Ulanov, 2015-01-23 20:10:26]

sergeyu@chromium.org changed reviewers:
+ kelvinp@chromium.org

[kelvinp, 2015-01-23 21:15:33]

https://codereview.chromium.org/874683002/diff/1/remoting/resources/remoting_...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/874683002/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:1: <?xml version="1.0"
encoding="UTF-8"?>
Duplicate 'change' (With this change change:) in issue description.

https://codereview.chromium.org/874683002/diff/1/remoting/webapp/crd/js/crd_m...
File remoting/webapp/crd/js/crd_main.js (right):

https://codereview.chromium.org/874683002/diff/1/remoting/webapp/crd/js/crd_m...
remoting/webapp/crd/js/crd_main.js:91: * TODO(kelvinp): Remove this function
once It2me is enabled on Chrome OS (See
Can you help me to move the TODO statement to line 100 to keep it relevant.

https://codereview.chromium.org/874683002/diff/1/remoting/webapp/crd/js/host_...
File remoting/webapp/crd/js/host_installer.js (right):

https://codereview.chromium.org/874683002/diff/1/remoting/webapp/crd/js/host_...
remoting/webapp/crd/js/host_installer.js:82:
remoting.HostInstaller.HOST_DOWNLOAD_URLS = {
With the new JS Compiler, you can make this truly private by:

Add the line below on line 28, before the constructor.

(function() {

Add the line below and the end of the file

})();

This wraps the class definition under the scope of an anonymous function so all
vars are truly private, as opposed to being part of the window namespace.  See
apps_v2_migration.js for an example.

then you can do

var HOST_DOWNLOAD_URLS_ = {
 ...
}

[Sergey Ulanov, 2015-01-23 21:26:19]

https://codereview.chromium.org/874683002/diff/1/remoting/resources/remoting_...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/874683002/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:1: <?xml version="1.0"
encoding="UTF-8"?>
On 2015/01/23 21:15:33, kelvinp wrote:
> Duplicate 'change' (With this change change:) in issue description.

Done.

https://codereview.chromium.org/874683002/diff/1/remoting/webapp/crd/js/crd_m...
File remoting/webapp/crd/js/crd_main.js (right):

https://codereview.chromium.org/874683002/diff/1/remoting/webapp/crd/js/crd_m...
remoting/webapp/crd/js/crd_main.js:91: * TODO(kelvinp): Remove this function
once It2me is enabled on Chrome OS (See
On 2015/01/23 21:15:33, kelvinp wrote:
> Can you help me to move the TODO statement to line 100 to keep it relevant.

I don't think we need this TODO at all. This logic is good as is even after
It2Me support is rolled out on ChromeOS. We just check that the host is already
installed or can be installed. Just removed the TODO.

https://codereview.chromium.org/874683002/diff/1/remoting/webapp/crd/js/host_...
File remoting/webapp/crd/js/host_installer.js (right):

https://codereview.chromium.org/874683002/diff/1/remoting/webapp/crd/js/host_...
remoting/webapp/crd/js/host_installer.js:82:
remoting.HostInstaller.HOST_DOWNLOAD_URLS = {
On 2015/01/23 21:15:33, kelvinp wrote:
> With the new JS Compiler, you can make this truly private by:
> 
> Add the line below on line 28, before the constructor.
> 
> (function() {
> 
> Add the line below and the end of the file
> 
> })();
> 
> This wraps the class definition under the scope of an anonymous function so
all
> vars are truly private, as opposed to being part of the window namespace.  See
> apps_v2_migration.js for an example.
> 
> then you can do
> 
> var HOST_DOWNLOAD_URLS_ = {
>  ...
> }

Done.

[Sergey Ulanov, 2015-01-23 21:30:37]

Also, made isInstalled() a static method in HostInstaller, for consistency with
canInstall().

[kelvinp, 2015-01-23 21:31:05]

lgtm

[Sergey Ulanov, 2015-01-23 21:34:02]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-01-23 21:35:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874683002/40001

[commit-bot: I haz the power, 2015-01-23 22:48:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-23 22:48:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-01-24 18:18:06]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-01-24 18:18:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/874683002/60001

[commit-bot: I haz the power, 2015-01-24 20:09:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-24 20:10:43]

Patchset 4 (id:??) landed as
https://crrev.com/3cf7e0eb1dab5c8f6399f287adaf4f5b88d352da
Cr-Commit-Position: refs/heads/master@{#313030}