Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: remoting/webapp/unittests/it2me_helpee_channel_unittest.js

Issue 874683002: Fix host installation on i686 Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/it2me_helpee_channel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/unittests/it2me_helpee_channel_unittest.js
diff --git a/remoting/webapp/unittests/it2me_helpee_channel_unittest.js b/remoting/webapp/unittests/it2me_helpee_channel_unittest.js
index 504affc1a80e4c32c4a14be781e8543b7545c553..4ccfb08e74a768d3d794dc9e7411b78fad37e07d 100644
--- a/remoting/webapp/unittests/it2me_helpee_channel_unittest.js
+++ b/remoting/webapp/unittests/it2me_helpee_channel_unittest.js
@@ -34,7 +34,6 @@ module('It2MeHelpeeChannel', {
// HostInstaller
hostInstaller = {
- isInstalled: function() {},
download: function() {}
};
@@ -64,7 +63,8 @@ test('hello() should return supportedFeatures', function() {
QUnit.asyncTest(
'isHostInstalled() should return false if host is not installed',
function() {
- sinon.stub(hostInstaller, 'isInstalled').returns(Promise.resolve(false));
+ sinon.stub(remoting.HostInstaller, 'isInstalled')
+ .returns(Promise.resolve(false));
var MessageTypes = remoting.It2MeHelpeeChannel.HangoutMessageTypes;
hangoutPort.onMessage.mock$fire({
@@ -72,6 +72,7 @@ QUnit.asyncTest(
});
window.requestAnimationFrame(function() {
+ remoting.HostInstaller.isInstalled.restore();
sinon.assert.calledWith(hangoutPort.postMessage, {
method: MessageTypes.IS_HOST_INSTALLED_RESPONSE,
result: false
@@ -82,7 +83,8 @@ QUnit.asyncTest(
QUnit.asyncTest('isHostInstalled() should return true if host is installed',
function() {
- sinon.stub(hostInstaller, 'isInstalled').returns(Promise.resolve(true));
+ sinon.stub(remoting.HostInstaller, 'isInstalled')
+ .returns(Promise.resolve(true));
var MessageTypes = remoting.It2MeHelpeeChannel.HangoutMessageTypes;
hangoutPort.onMessage.mock$fire({
@@ -90,6 +92,7 @@ QUnit.asyncTest('isHostInstalled() should return true if host is installed',
});
window.requestAnimationFrame(function() {
+ remoting.HostInstaller.isInstalled.restore();
sinon.assert.calledWith(hangoutPort.postMessage, {
method: MessageTypes.IS_HOST_INSTALLED_RESPONSE,
result: true
« no previous file with comments | « remoting/webapp/crd/js/it2me_helpee_channel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698