Issue 87453003: Less magic numbers in converting CSS lengths of cm/mm/pc/pt types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 87453003: Less magic numbers in converting CSS lengths of cm/mm/pc/pt types. (Closed)

Created:
7 years ago by Timothy Loh

Modified:
7 years ago

Reviewers:
Julien - ping for review

CC:
blink-reviews, krit, dglazkov+blink, f(malita), darktears, pdr, apavlov+blink_chromium.org, Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink@master

Visibility:
Public.

More Reviews

Description

Less magic numbers in converting CSS lengths of cm/mm/pc/pt types. BUG=322365 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162717

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -23 lines)			Patch
M	Source/core/css/CSSHelper.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/core/css/CSSPrimitiveValue.cpp	View		3 chunks	+9 lines, -10 lines	0 comments	Download
M	Source/core/svg/SVGLengthContext.cpp	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/core/svg/SVGSVGElement.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

Awesome! lgtm https://codereview.chromium.org/87453003/diff/60001/Source/core/css/CSSHelper.h File Source/core/css/CSSHelper.h (right): https://codereview.chromium.org/87453003/diff/60001/Source/core/css/CSSHelper.h#newcode33 Source/core/css/CSSHelper.h:33: const double cssPixelsPerCentimeter = cssPixelsPerInch / 2.54; ...

7 years ago (2013-11-26 23:57:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/87453003/80001

7 years ago (2013-11-27 00:04:36 UTC) #3

Message was sent while issue was closed.

Change committed as 162717

Expand Messages | Collapse Messages

Issue 87453003: Less magic numbers in converting CSS lengths of cm/mm/pc/pt types. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages