Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 87453003: Less magic numbers in converting CSS lengths of cm/mm/pc/pt types. (Closed)

Created:
7 years ago by Timothy Loh
Modified:
7 years ago
CC:
blink-reviews, krit, dglazkov+blink, f(malita), darktears, pdr, apavlov+blink_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Less magic numbers in converting CSS lengths of cm/mm/pc/pt types. BUG=322365 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162717

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M Source/core/css/CSSHelper.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 3 chunks +9 lines, -10 lines 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Timothy Loh
7 years ago (2013-11-26 23:35:35 UTC) #1
Julien - ping for review
Awesome! lgtm https://codereview.chromium.org/87453003/diff/60001/Source/core/css/CSSHelper.h File Source/core/css/CSSHelper.h (right): https://codereview.chromium.org/87453003/diff/60001/Source/core/css/CSSHelper.h#newcode33 Source/core/css/CSSHelper.h:33: const double cssPixelsPerCentimeter = cssPixelsPerInch / 2.54; ...
7 years ago (2013-11-26 23:57:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/87453003/80001
7 years ago (2013-11-27 00:04:36 UTC) #3
commit-bot: I haz the power
7 years ago (2013-11-27 01:42:49 UTC) #4
Message was sent while issue was closed.
Change committed as 162717

Powered by Google App Engine
This is Rietveld 408576698