Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Side by Side Diff: Source/core/css/CSSHelper.h

Issue 87453003: Less magic numbers in converting CSS lengths of cm/mm/pc/pt types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSPrimitiveValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2009 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 11 matching lines...) Expand all
22 #ifndef CSSHelper_h 22 #ifndef CSSHelper_h
23 #define CSSHelper_h 23 #define CSSHelper_h
24 24
25 #include "wtf/Forward.h" 25 #include "wtf/Forward.h"
26 26
27 namespace WebCore { 27 namespace WebCore {
28 28
29 // We always assume 96 CSS pixels in a CSS inch. This is the cold hard truth of the Web. 29 // We always assume 96 CSS pixels in a CSS inch. This is the cold hard truth of the Web.
30 // At high DPI, we may scale a CSS pixel, but the ratio of the CSS pixel to the so-called 30 // At high DPI, we may scale a CSS pixel, but the ratio of the CSS pixel to the so-called
31 // "absolute" CSS length units like inch and pt is always fixed and never change s. 31 // "absolute" CSS length units like inch and pt is always fixed and never change s.
32 const float cssPixelsPerInch = 96; 32 const double cssPixelsPerInch = 96;
33 const double cssPixelsPerCentimeter = cssPixelsPerInch / 2.54;
Julien - ping for review 2013/11/26 23:57:41 Nit: I would put a comment with the conversion inc
34 const double cssPixelsPerMillimeter = cssPixelsPerCentimeter / 10;
35 const double cssPixelsPerPoint = cssPixelsPerInch / 72;
36 const double cssPixelsPerPica = cssPixelsPerInch / 6;
33 37
34 } // namespace WebCore 38 } // namespace WebCore
35 39
36 #endif // CSSHelper_h 40 #endif // CSSHelper_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/CSSPrimitiveValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698