Issue 874483007: Make sure ResourceBundle::GetImageSkiaNamed running on UI thread.

Issue 874483007: Make sure ResourceBundle::GetImageSkiaNamed running on UI thread. (Closed)

Created:
5 years, 11 months ago by Jun Mukai

Modified:
5 years, 11 months ago

Reviewers:
xiyuan, oshima

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Make sure ResourceBundle::GetImageSkiaNamed running on UI thread. Because ImageSkia is not thread-safe, we should restrict the caller thread of GetImageSkiaNamed() to the UI thread only. BUG=449277 R=oshima@chromium.org, xiyuan@chromium.org TEST=manually Committed: https://crrev.com/c9ff196ec6e6b4da30c06631b30a2cea961dbfbb Cr-Commit-Position: refs/heads/master@{#312991}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -12 lines)			Patch
	M	chrome/browser/ui/webui/theme_source.cc	View	1	2 chunks	+29 lines, -12 lines	0 comments	Download

Total messages: 9 (2 generated)

Jun Mukai

xiyuan, could you review this? you are an owner of c/b/ui/webui

5 years, 11 months ago (2015-01-24 00:10:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874483007/20001

5 years, 11 months ago (2015-01-24 00:33:48 UTC) #7

commit-bot: I haz the power

5 years, 11 months ago (2015-01-24 02:03:55 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/c9ff196ec6e6b4da30c06631b30a2cea961dbfbb
Cr-Commit-Position: refs/heads/master@{#312991}