Make sure ResourceBundle::GetImageSkiaNamed running on UI thread.

chrome/browser/ui/webui/theme_source.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/theme_source.h"
 
 #include "base/memory/ref_counted_memory.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 22 matching lines @@
 
 std::string GetThemePath() {
   return std::string(content::kChromeUIScheme) + "://" +
          std::string(chrome::kChromeUIThemePath) + "/";
 }
 
 // use a resource map rather than hard-coded strings.
 static const char* kNewTabCSSPath = "css/new_tab_theme.css";
 static const char* kNewIncognitoTabCSSPath = "css/incognito_new_tab_theme.css";
 
+void ProcessImageOnUIThread(const gfx::ImageSkia& image,
+                            float scale_factor,
+                            scoped_refptr<base::RefCountedBytes> data) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+  const gfx::ImageSkiaRep& rep = image.GetRepresentation(scale_factor);
+  gfx::PNGCodec::EncodeBGRASkBitmap(
+      rep.sk_bitmap(), false /* discard transparency */, &data->data());
+}
+
+void ProcessResourceOnUIThread(int resource_id,
+                               float scale_factor,
+                               scoped_refptr<base::RefCountedBytes> data) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+  ProcessImageOnUIThread(
+      *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(resource_id),
+      scale_factor, data);
+}
+
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // ThemeSource, public:
 
 ThemeSource::ThemeSource(Profile* profile)
     : profile_(profile->GetOriginalProfile()) {
   NTPResourceCache::WindowType win_type = NTPResourceCache::GetWindowType(
       profile_, NULL);
   css_bytes_ =
@@ skipping 119 matching lines @@
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
   if (ui::GetScaleForScaleFactor(rb.GetMaxScaleFactor()) >= scale_factor) {
     SendThemeBitmap(callback, resource_id, scale_factor);
     return;
   }
 
   // Otherwise, we should use gfx::ImageSkia to obtain the data. ImageSkia can
   // rescale the bitmap if its backend doesn't contain the representation for
   // the specified scale factor. This is the fallback path in case chrome is
   // shipped without 2x resource pack but needs to use HighDPI display, which
-  // can happen in ChromeOS.
-  // TODO(mukai): remove this method itself when we ship 2x resource to all
-  // ChromeOS devices.
-  gfx::ImageSkia image;
+  // can happen in ChromeOS or Linux.
+  scoped_refptr<base::RefCountedBytes> data(new base::RefCountedBytes());
   if (BrowserThemePack::IsPersistentImageID(resource_id)) {
     DCHECK_CURRENTLY_ON(BrowserThread::UI);
     ui::ThemeProvider* tp = ThemeServiceFactory::GetForProfile(profile_);
     DCHECK(tp);
 
-    image = *tp->GetImageSkiaNamed(resource_id);
+    ProcessImageOnUIThread(*tp->GetImageSkiaNamed(resource_id), scale_factor,
+                           data);
+    callback.Run(data.get());
   } else {
     DCHECK_CURRENTLY_ON(BrowserThread::IO);
-    image = *rb.GetImageSkiaNamed(resource_id);
+    // Fetching image data in ResourceBundle should happen on the UI thread. See
+    // crbug.com/449277
+    content::BrowserThread::PostTaskAndReply(
+        content::BrowserThread::UI, FROM_HERE,
+        base::Bind(&ProcessResourceOnUIThread, resource_id, scale_factor, data),
+        base::Bind(callback, data));
   }
-
-  const gfx::ImageSkiaRep& rep = image.GetRepresentation(scale_factor);
-  scoped_refptr<base::RefCountedBytes> data(new base::RefCountedBytes());
-  gfx::PNGCodec::EncodeBGRASkBitmap(
-      rep.sk_bitmap(), false /* discard transparency */, &data->data());
-  callback.Run(data.get());
 }