Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9394)

Unified Diff: chrome/common/BUILD.gn

Issue 874413003: Add targets for generating version files in Windows GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index d6a03e0fc327ee420e593cd2d16d697999e63115..d0a1ae716dcc4515c6f2fd8cb2049c5f03c6eff1 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -266,9 +266,11 @@ static_library("constants") {
"pref_names.h",
"widevine_cdm_constants.cc",
"widevine_cdm_constants.h",
+ "$target_gen_dir/chrome_version.cc",
]
deps = [
+ ":make_chrome_version",
"//base",
"//base/third_party/dynamic_annotations",
"//components/bookmarks/common",
@@ -282,6 +284,26 @@ static_library("constants") {
}
}
+action("make_chrome_version") {
+ script = "//chrome/tools/build/make_version_cc.py"
+ outputs = [
+ "$target_gen_dir/chrome_version.cc",
+ ]
+
+ version_full = exec_script("//build/util/version.py",
brettw 2015/01/27 23:58:07 I think we should be able to work around doing thi
+ [
+ "-f",
+ rebase_path("//chrome/VERSION", root_build_dir),
+ "-t @MAJOR@.@MINOR@.@BUILD@.@PATCH@",
Slava Chigrin 2015/01/26 23:29:09 See https://code.google.com/p/chromium/codesearch#
+ ],
+ "trim string",
+ [ "//chrome/VERSION" ])
+ args = [
+ rebase_path("$target_gen_dir/chrome_version.cc", root_build_dir),
+ "$version_full",
Slava Chigrin 2015/01/26 23:29:09 See https://code.google.com/p/chromium/codesearch#
+ ]
+}
+
source_set("test_support") {
testonly = true
visibility = [ "//chrome/test:test_support" ]
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698