Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 873973003: Add missing FrameState for Runtime_CreateArrayLiteral. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing FrameState for Runtime_CreateArrayLiteral. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-451013 BUG=chromium:451013 LOG=N Committed: https://crrev.com/00f3f99221965e023b511d175ceecee3e72c9842 Cr-Commit-Position: refs/heads/master@{#26268}

Patch Set 1 #

Patch Set 2 : Port to other architectures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ast.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-451013.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 11 months ago (2015-01-26 11:50:35 UTC) #1
Jarin
lgtm
5 years, 11 months ago (2015-01-26 11:52:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873973003/1
5 years, 11 months ago (2015-01-26 11:52:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873973003/20001
5 years, 11 months ago (2015-01-26 12:40:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-26 12:45:32 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 12:45:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00f3f99221965e023b511d175ceecee3e72c9842
Cr-Commit-Position: refs/heads/master@{#26268}

Powered by Google App Engine
This is Rietveld 408576698