Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 873973003: Add missing FrameState for Runtime_CreateArrayLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Port to other architectures. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/linkage.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1799 matching lines...) Expand 10 before | Expand all | Expand 10 after
1810 __ push(Immediate(Smi::FromInt(flags))); 1810 __ push(Immediate(Smi::FromInt(flags)));
1811 __ CallRuntime(Runtime::kCreateArrayLiteral, 4); 1811 __ CallRuntime(Runtime::kCreateArrayLiteral, 4);
1812 } else { 1812 } else {
1813 __ mov(ebx, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset)); 1813 __ mov(ebx, Operand(ebp, JavaScriptFrameConstants::kFunctionOffset));
1814 __ mov(eax, FieldOperand(ebx, JSFunction::kLiteralsOffset)); 1814 __ mov(eax, FieldOperand(ebx, JSFunction::kLiteralsOffset));
1815 __ mov(ebx, Immediate(Smi::FromInt(expr->literal_index()))); 1815 __ mov(ebx, Immediate(Smi::FromInt(expr->literal_index())));
1816 __ mov(ecx, Immediate(constant_elements)); 1816 __ mov(ecx, Immediate(constant_elements));
1817 FastCloneShallowArrayStub stub(isolate(), allocation_site_mode); 1817 FastCloneShallowArrayStub stub(isolate(), allocation_site_mode);
1818 __ CallStub(&stub); 1818 __ CallStub(&stub);
1819 } 1819 }
1820 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
1820 1821
1821 bool result_saved = false; // Is the result saved to the stack? 1822 bool result_saved = false; // Is the result saved to the stack?
1822 1823
1823 // Emit code to evaluate all the non-constant subexpressions and to store 1824 // Emit code to evaluate all the non-constant subexpressions and to store
1824 // them into the newly cloned array. 1825 // them into the newly cloned array.
1825 for (int i = 0; i < length; i++) { 1826 for (int i = 0; i < length; i++) {
1826 Expression* subexpr = subexprs->at(i); 1827 Expression* subexpr = subexprs->at(i);
1827 // If the subexpression is a literal or a simple materialized literal it 1828 // If the subexpression is a literal or a simple materialized literal it
1828 // is already set in the cloned array. 1829 // is already set in the cloned array.
1829 if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue; 1830 if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue;
(...skipping 3452 matching lines...) Expand 10 before | Expand all | Expand 10 after
5282 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5283 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5283 Assembler::target_address_at(call_target_address, 5284 Assembler::target_address_at(call_target_address,
5284 unoptimized_code)); 5285 unoptimized_code));
5285 return OSR_AFTER_STACK_CHECK; 5286 return OSR_AFTER_STACK_CHECK;
5286 } 5287 }
5287 5288
5288 5289
5289 } } // namespace v8::internal 5290 } } // namespace v8::internal
5290 5291
5291 #endif // V8_TARGET_ARCH_IA32 5292 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/compiler/linkage.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698