Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 873963003: Remove more mouse-specific code (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
eseidel1, eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove more mouse-specific code This CL removes a bunch of unused mouse-related code, including the MouseRelatedEvent base class. R=eseidel@google.com, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/39854a8c0d1e7c3459296386cae3fbd81828a400

Patch Set 1 #

Patch Set 2 : Build fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -811 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/dom/Element.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Node.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/editing/FrameSelection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/editing/FrameSelection.cpp View 3 chunks +1 line, -12 lines 0 comments Download
M sky/engine/core/events/Event.h View 1 chunk +0 lines, -19 lines 0 comments Download
M sky/engine/core/events/Event.idl View 1 chunk +0 lines, -19 lines 0 comments Download
M sky/engine/core/events/EventTarget.cpp View 1 chunk +4 lines, -25 lines 0 comments Download
M sky/engine/core/events/EventTypeNames.in View 1 chunk +0 lines, -8 lines 0 comments Download
D sky/engine/core/events/MouseRelatedEvent.h View 1 chunk +0 lines, -91 lines 0 comments Download
D sky/engine/core/events/MouseRelatedEvent.cpp View 1 chunk +0 lines, -192 lines 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/AutoscrollController.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/page/Chrome.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/Chrome.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/page/ChromeClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/EventHandler.h View 1 4 chunks +0 lines, -40 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 14 chunks +1 line, -225 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/platform/PlatformEvent.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/platform/scroll/ScrollAnimator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.cpp View 3 chunks +0 lines, -33 lines 0 comments Download
M sky/engine/public/web/WebViewClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/public/web/WebWidget.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-24 08:48:16 UTC) #1
eseidel1
lgtm
5 years, 11 months ago (2015-01-24 18:49:06 UTC) #3
abarth-chromium
5 years, 11 months ago (2015-01-24 19:18:39 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
39854a8c0d1e7c3459296386cae3fbd81828a400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698