Issue 873883003: Enable strict checks for {virtual,override,final} on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 873883003: Enable strict checks for {virtual,override,final} on CrOS. (Closed)

Created:
5 years, 11 months ago by dcheng

Modified:
5 years, 11 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Enable strict checks for {virtual,override,final} on CrOS. BUG=417463 Committed: https://crrev.com/fee9dbf09814cb64c3cb3bea738bec8030dd521f Cr-Commit-Position: refs/heads/master@{#312996}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

dcheng

As of 5 minutes ago, CrOS was building cleanly with this. Fingers crossed.

5 years, 11 months ago (2015-01-24 00:39:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873883003/1

5 years, 11 months ago (2015-01-24 00:58:52 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-24 02:14:10 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fee9dbf09814cb64c3cb3bea738bec8030dd521f
Cr-Commit-Position: refs/heads/master@{#312996}