build/common.gypi - Issue 873883003: Enable strict checks for {virtual,override,final} on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 873883003: Enable strict checks for {virtual,override,final} on CrOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 2da69588425168a9ae33fd58ba12149d0db5ed41..45993b591b99ab2cd6f8760e36d4d01bb47f49de 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2143,7 +2143,7 @@

'conditions': [

# TODO(dcheng): https://crbug.com/417463 -- work to enable this flag

# on all platforms is currently underway.

- ['(OS=="linux" and chromeos==0) or OS=="mac" or OS=="ios"', {

+ ['OS=="linux" or OS=="mac" or OS=="ios"', {

'clang_chrome_plugins_flags': [

'-Xclang',

'-plugin-arg-find-bad-constructs',

« no previous file with comments | « no previous file | no next file » | no next file with comments »