Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 873843002: [net] Clang-format filename_util_unittest.cc (Closed)

Created:
5 years, 11 months ago by asanka
Modified:
5 years, 10 months ago
Reviewers:
jkarlin
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@filename-sanitization
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[net] Clang-format filename_util_unittest.cc Upcoming changes to filename_util are unreviewable if they include material code changes and formatting changes. This CL just includes formatting changes and is the result of running: 'clang-format -i --style=Chromium filename_util_unittest.cc'. Depends on: https://codereview.chromium.org/869823003 Needed by : https://codereview.chromium.org/869233006 BUG=444102 Committed: https://crrev.com/13cc94a3430af79bb6fae21576bc688e7431b94b Cr-Commit-Position: refs/heads/master@{#314399}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Rebase + address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+508 lines, -676 lines) Patch
M net/base/filename_util_unittest.cc View 1 2 9 chunks +508 lines, -676 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
asanka
Can you check if this is the intended formatting?
5 years, 10 months ago (2015-01-30 23:42:13 UTC) #2
jkarlin
lgtm with nits, though I'm not an owner. https://codereview.chromium.org/873843002/diff/20001/net/base/filename_util_unittest.cc File net/base/filename_util_unittest.cc (right): https://codereview.chromium.org/873843002/diff/20001/net/base/filename_util_unittest.cc#newcode251 net/base/filename_util_unittest.cc:251: //{L"/foo%5Cbar.txt", ...
5 years, 10 months ago (2015-01-31 00:59:43 UTC) #3
asanka
Thanks! https://codereview.chromium.org/873843002/diff/20001/net/base/filename_util_unittest.cc File net/base/filename_util_unittest.cc (right): https://codereview.chromium.org/873843002/diff/20001/net/base/filename_util_unittest.cc#newcode251 net/base/filename_util_unittest.cc:251: //{L"/foo%5Cbar.txt", "file://foo\\bar.txt"}, On 2015/01/31 at 00:59:43, jkarlin wrote: ...
5 years, 10 months ago (2015-02-03 19:49:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873843002/40001
5 years, 10 months ago (2015-02-03 19:51:08 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-03 20:32:31 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 20:35:25 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/13cc94a3430af79bb6fae21576bc688e7431b94b
Cr-Commit-Position: refs/heads/master@{#314399}

Powered by Google App Engine
This is Rietveld 408576698