[net] Cleanup filename_util and make it portable.

[net] Cleanup filename_util and make it portable.

The interface for filename sanitization is confusing and error prone.
This CL cleans up the interface and changes the behavior to keep up with
changes made to filename sanitization made in base/i18n/file_util_icu.

- net::GetSuggestedFilename() is now gone. This was redundant with
  net::GenerateFileName() which does the same thing.

- net::GenerateSafeFileName() is now net::EnsureSafePortableFileName().

- net::GenerateSafeFileName() was only checking if a given filename has
  a safe extension and whether it was a reserved name.
  net::EnsureSafePortableFileName() is a comprehensive filename
  sanitization function that deals with illegal filename characters in
  addition to the checks previously done by net::GenerateSafeFileName().

- As the name suggests, net::EnsureSafePortableFileName() performs the
  same set of tests on all platforms.

Depends on: https://codereview.chromium.org/873843002

BUG=444102
R=mef@chromium.org

[asanka, 2015-01-30 23:45:26]

mef: Can you look at //net? Once those changes are reviewed, I can add OWNERS
for the rest of the review.

[asanka, 2015-02-05 22:41:30]

On 2015/01/30 at 23:45:26, asanka wrote:
> mef: Can you look at //net? Once those changes are reviewed, I can add OWNERS
for the rest of the review.

Ping?

[mef, 2016-06-24 20:20:49]

Description was changed from

==========
[net] Cleanup filename_util and make it portable.

The interface for filename sanitization is confusing and error prone.
This CL cleans up the interface and changes the behavior to keep up with
changes made to filename sanitization made in base/i18n/file_util_icu.

- net::GetSuggestedFilename() is now gone. This was redundant with
  net::GenerateFileName() which does the same thing.

- net::GenerateSafeFileName() is now net::EnsureSafePortableFileName().

- net::GenerateSafeFileName() was only checking if a given filename has
  a safe extension and whether it was a reserved name.
  net::EnsureSafePortableFileName() is a comprehensive filename
  sanitization function that deals with illegal filename characters in
  addition to the checks previously done by net::GenerateSafeFileName().

- As the name suggests, net::EnsureSafePortableFileName() performs the
  same set of tests on all platforms.

Depends on: https://codereview.chromium.org/873843002

BUG=444102
R=mef@chromium.org
==========

to

==========
[net] Cleanup filename_util and make it portable.

The interface for filename sanitization is confusing and error prone.
This CL cleans up the interface and changes the behavior to keep up with
changes made to filename sanitization made in base/i18n/file_util_icu.

- net::GetSuggestedFilename() is now gone. This was redundant with
  net::GenerateFileName() which does the same thing.

- net::GenerateSafeFileName() is now net::EnsureSafePortableFileName().

- net::GenerateSafeFileName() was only checking if a given filename has
  a safe extension and whether it was a reserved name.
  net::EnsureSafePortableFileName() is a comprehensive filename
  sanitization function that deals with illegal filename characters in
  addition to the checks previously done by net::GenerateSafeFileName().

- As the name suggests, net::EnsureSafePortableFileName() performs the
  same set of tests on all platforms.

Depends on: https://codereview.chromium.org/873843002

BUG=444102
R=mef@chromium.org
==========

[mef, 2016-06-24 20:20:49]

mef@chromium.org changed reviewers:
- mef@chromium.org