Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 873703002: Fixed Hydrogen environment handling for mul-i on ARM and ARM64. (Closed)

Created:
5 years, 11 months ago by Sven Panne
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixed Hydrogen environment handling for mul-i on ARM and ARM64. The whole logic in DoMul makes me cry, so I made only the minimal change to fix the issue... BUG=v8:451322 LOG=y Committed: https://crrev.com/a7d67a64f11100434b196143e2ba516f8c13697a Cr-Commit-Position: refs/heads/master@{#26261}

Patch Set 1 #

Patch Set 2 : Fixed ARM64, too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M src/arm/lithium-arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-451322.js View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sven Panne
5 years, 11 months ago (2015-01-23 13:59:11 UTC) #2
Benedikt Meurer
URGS ^W LGTM
5 years, 11 months ago (2015-01-23 14:08:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873703002/1
5 years, 11 months ago (2015-01-23 14:09:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2314)
5 years, 11 months ago (2015-01-23 14:30:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873703002/20001
5 years, 11 months ago (2015-01-26 08:06:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-26 08:35:55 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 08:36:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7d67a64f11100434b196143e2ba516f8c13697a
Cr-Commit-Position: refs/heads/master@{#26261}

Powered by Google App Engine
This is Rietveld 408576698