Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: src/arm64/lithium-arm64.cc

Issue 873703002: Fixed Hydrogen environment handling for mul-i on ARM and ARM64. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed ARM64, too. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | test/mjsunit/regress/regress-451322.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/lithium-arm64.cc
diff --git a/src/arm64/lithium-arm64.cc b/src/arm64/lithium-arm64.cc
index 2d5f7f297c3deea0be673e4a73fda67e8bd8ef9a..d667f719e89138ab3d1ce07808867eefe8a533d4 100644
--- a/src/arm64/lithium-arm64.cc
+++ b/src/arm64/lithium-arm64.cc
@@ -1963,7 +1963,9 @@ LInstruction* LChunkBuilder::DoMul(HMul* instr) {
: UseRegisterAtStart(least_const);
LInstruction* result =
DefineAsRegister(new(zone()) LMulConstIS(left, right));
- if ((bailout_on_minus_zero && constant <= 0) || can_overflow) {
+ if ((bailout_on_minus_zero && constant <= 0) ||
+ (can_overflow && constant != 1 &&
+ base::bits::IsPowerOfTwo32(constant_abs))) {
result = AssignEnvironment(result);
}
return result;
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | test/mjsunit/regress/regress-451322.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698