Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 873473003: Update {virtual,override,final} to follow C++11 style in extensions, round 2. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
scheib
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in extensions, round 2. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61 Cr-Commit-Position: refs/heads/master@{#312737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M extensions/browser/api/audio/audio_service_chromeos.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M extensions/browser/api/vpn_provider/vpn_provider_api.h View 6 chunks +11 lines, -11 lines 0 comments Download
M extensions/browser/api/vpn_provider/vpn_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/webcam_private/webcam_private_api.h View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/shell/browser/shell_audio_controller_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_network_controller_chromeos.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
5 years, 11 months ago (2015-01-22 22:32:17 UTC) #2
scheib
lgtm
5 years, 11 months ago (2015-01-22 23:03:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873473003/1
5 years, 11 months ago (2015-01-22 23:09:29 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-23 01:12:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873473003/1
5 years, 11 months ago (2015-01-23 01:17:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 01:44:03 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 01:46:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c4f4ee156220fa7b058456d536d4e6e7f9b5d61
Cr-Commit-Position: refs/heads/master@{#312737}

Powered by Google App Engine
This is Rietveld 408576698