extensions/browser/api/vpn_provider/vpn_service.cc - Issue 873473003: Update {virtual,override,final} to follow C++11 style in extensions, round 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/vpn_provider/vpn_service.cc

Issue 873473003: Update {virtual,override,final} to follow C++11 style in extensions, round 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/vpn_provider/vpn_provider_api.h ('k') | extensions/browser/api/webcam_private/webcam_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/vpn_provider/vpn_service.cc

diff --git a/extensions/browser/api/vpn_provider/vpn_service.cc b/extensions/browser/api/vpn_provider/vpn_service.cc

index f2a7efb9faed535691074372eb15aca13b042851..2ebc3ff7f3b86b57cafce8f71a5762f8837766fe 100644

--- a/extensions/browser/api/vpn_provider/vpn_service.cc

+++ b/extensions/browser/api/vpn_provider/vpn_service.cc

@@ -59,7 +59,7 @@ class VpnService::VpnConfiguration : public ShillThirdPartyVpnObserver {

const std::string& configuration_name,

const std::string& key,

base::WeakPtr<VpnService> vpn_service);

- ~VpnConfiguration();

+ ~VpnConfiguration() override;

const std::string& extension_id() const { return extension_id_; }

const std::string& configuration_name() const { return configuration_name_; }