Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 873353004: Remove InstallHost from the DaemonController. (Closed)

Created:
5 years, 10 months ago by weitao
Modified:
5 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove InstallHost from the DaemonController. The InstallHost functionality is no longer used now that our Npapi plugin is gone. I am removing it in preparation for the removal of ElevatedDaemonController. BUG=453172 Committed: https://crrev.com/2a4fd78e5763cd30fd766609790b69bb5aab8649 Cr-Commit-Position: refs/heads/master@{#313857}

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -576 lines) Patch
M remoting/host/setup/daemon_controller.h View 3 chunks +0 lines, -9 lines 3 comments Download
M remoting/host/setup/daemon_controller.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_delegate_linux.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_delegate_mac.mm View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_win.h View 4 chunks +0 lines, -16 lines 0 comments Download
M remoting/host/setup/daemon_controller_delegate_win.cc View 3 chunks +24 lines, -51 lines 3 comments Download
D remoting/host/setup/daemon_installer_win.h View 1 chunk +0 lines, -52 lines 0 comments Download
D remoting/host/setup/daemon_installer_win.cc View 1 chunk +0 lines, -412 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M remoting/remoting_host.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
weitao
PTAL. https://codereview.chromium.org/873353004/diff/1/remoting/host/setup/daemon_controller_delegate_win.cc File remoting/host/setup/daemon_controller_delegate_win.cc (right): https://codereview.chromium.org/873353004/diff/1/remoting/host/setup/daemon_controller_delegate_win.cc#newcode134 remoting/host/setup/daemon_controller_delegate_win.cc:134: HWND GetTopLevelWindow(HWND window) { This will be removed ...
5 years, 10 months ago (2015-01-29 18:53:51 UTC) #2
Sergey Ulanov
I think DaemonController::State can be cleaned up as well. https://codereview.chromium.org/873353004/diff/1/remoting/host/setup/daemon_controller.h File remoting/host/setup/daemon_controller.h (right): https://codereview.chromium.org/873353004/diff/1/remoting/host/setup/daemon_controller.h#newcode40 remoting/host/setup/daemon_controller.h:40: ...
5 years, 10 months ago (2015-01-29 19:00:32 UTC) #3
weitao
https://codereview.chromium.org/873353004/diff/1/remoting/host/setup/daemon_controller.h File remoting/host/setup/daemon_controller.h (right): https://codereview.chromium.org/873353004/diff/1/remoting/host/setup/daemon_controller.h#newcode40 remoting/host/setup/daemon_controller.h:40: STATE_INSTALLING = 1, On 2015/01/29 19:00:32, Sergey Ulanov wrote: ...
5 years, 10 months ago (2015-01-29 23:50:58 UTC) #4
Sergey Ulanov
lgtm https://codereview.chromium.org/873353004/diff/1/remoting/host/setup/daemon_controller.h File remoting/host/setup/daemon_controller.h (right): https://codereview.chromium.org/873353004/diff/1/remoting/host/setup/daemon_controller.h#newcode40 remoting/host/setup/daemon_controller.h:40: STATE_INSTALLING = 1, On 2015/01/29 23:50:57, weitaosu wrote: ...
5 years, 10 months ago (2015-01-29 23:58:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873353004/1
5 years, 10 months ago (2015-01-30 01:25:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 02:13:03 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 02:13:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a4fd78e5763cd30fd766609790b69bb5aab8649
Cr-Commit-Position: refs/heads/master@{#313857}

Powered by Google App Engine
This is Rietveld 408576698