Remove InstallHost from the DaemonController.

remoting/host/setup/daemon_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_SETUP_DAEMON_CONTROLLER_H_
 #define REMOTING_HOST_SETUP_DAEMON_CONTROLLER_H_
 
 #include <queue>
 #include <string>
 
@@ skipping 19 matching lines @@
     // Placeholder state for platforms on which the daemon process is not
     // implemented. The web-app will not show the corresponding UI. This value
     // will eventually be deprecated or removed.
     STATE_NOT_IMPLEMENTED = -1,
     // The daemon is not installed. This is functionally equivalent to
     // STATE_STOPPED, but the start method is expected to be significantly
     // slower, and might involve user interaction. It might be appropriate to
     // indicate this in the UI.
     STATE_NOT_INSTALLED = 0,
     // The daemon is being installed.
     STATE_INSTALLING = 1,

[Sergey Ulanov, 2015/01/29 19:00:32]

These 3 states above can be removed now.

[weitao, 2015/01/29 23:50:57]

How about I clean this up in a subsequent CL which will remove them in the
webapp as well as here? That way each CL is more Isolated and easier to review.

[Sergey Ulanov, 2015/01/29 23:58:39]

sgtm

     // The daemon is installed but not running. Call Start to start it.
     STATE_STOPPED = 2,
     // The daemon process is starting.
     STATE_STARTING = 3,
     // The daemon process is running. Call Start again to change the PIN or
     // Stop to stop it.
     STATE_STARTED = 4,
     // The daemon process is stopping.
     STATE_STOPPING = 5,
     // The state cannot be determined. This could indicate that the plugin
@@ skipping 63 matching lines @@
     virtual ~Delegate() {}
 
     // Return the "installed/running" state of the daemon process. This method
     // should avoid accessing any data members of the implementation.
     virtual State GetState() = 0;
 
     // Queries current host configuration. Any values that might be security
     // sensitive have been filtered out.
     virtual scoped_ptr<base::DictionaryValue> GetConfig() = 0;
 
-    // Download and install the host component. |done| is invoked on the
-    // calling thread when the operation is completed.
-    virtual void InstallHost(const CompletionCallback& done) = 0;
-
     // Starts the daemon process. This may require that the daemon be
     // downloaded and installed. |done| is invoked on the calling thread when
     // the operation is completed.
     virtual void SetConfigAndStart(
         scoped_ptr<base::DictionaryValue> config,
         bool consent,
         const CompletionCallback& done) = 0;
 
     // Updates current host configuration with the values specified in
     // |config|. Any value in the existing configuration that isn't specified in
@@ skipping 30 matching lines @@
   // webapp. In most cases it requires IO operations, so it may block
   // the user interface. Replace it with asynchronous notifications,
   // e.g. with StartStateNotifications()/StopStateNotifications() methods.
   State GetState();
 
   // Queries current host configuration. The |done| is called
   // after the configuration is read, and any values that might be security
   // sensitive have been filtered out.
   void GetConfig(const GetConfigCallback& done);
 
-  // Download and install the host component. |done| is called when the
-  // operation is finished or fails.
-  void InstallHost(const CompletionCallback& done);
-
   // Start the daemon process. This may require that the daemon be
   // downloaded and installed. |done| is called when the
   // operation is finished or fails.
   //
   // TODO(sergeyu): This method writes config and starts the host -
   // these two steps are merged for simplicity. Consider splitting it
   // into SetConfig() and Start() once we have basic host setup flow
   // working.
   void SetConfigAndStart(scoped_ptr<base::DictionaryValue> config,
                          bool consent,
@@ skipping 25 matching lines @@
 
   // Get the user's consent to crash reporting.
   void GetUsageStatsConsent(const GetUsageStatsConsentCallback& done);
 
  private:
   friend class base::RefCountedThreadSafe<DaemonController>;
   virtual ~DaemonController();
 
   // Blocking helper methods used to call the delegate.
   void DoGetConfig(const GetConfigCallback& done);
-  void DoInstallHost(const CompletionCallback& done);
   void DoSetConfigAndStart(scoped_ptr<base::DictionaryValue> config,
                            bool consent,
                            const CompletionCallback& done);
   void DoUpdateConfig(scoped_ptr<base::DictionaryValue> config,
                       const CompletionCallback& done);
   void DoStop(const CompletionCallback& done);
   void DoSetWindow(void* window_handle, const base::Closure& done);
   void DoGetVersion(const GetVersionCallback& done);
   void DoGetUsageStatsConsent(const GetUsageStatsConsentCallback& done);
 
@@ skipping 30 matching lines @@
   scoped_ptr<Delegate> delegate_;
 
   std::queue<base::Closure> pending_requests_;
 
   DISALLOW_COPY_AND_ASSIGN(DaemonController);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_SETUP_DAEMON_CONTROLLER_H_