Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 873313007: Revert of Disable -Wl,-z,defs on mipsel to suppress ffmpeg error (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
Nico, Zachary Kuznia
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable -Wl,-z,defs on mipsel to suppress ffmpeg error (patchset #2 id:20001 of https://codereview.chromium.org/864193002/) Reason for revert: ffmpeg issue was fixed here: https://gerrit.chromium.org/gerrit/#/c/73566/ which was rolled into chromium here: https://crrev.com/313130 Original issue's description: > Disable -Wl,-z,defs on mipsel to suppress ffmpeg error > > The ffmpeg build on mips is broken which manifests in build errors when > z,defs is specified. The owners of this build would like the compile > time error to be suppressed for now while they work on a proper fix. > > BUG=450771, 371125 > > Committed: https://crrev.com/9267528ad62c796f30c9f51f398fbfa29f0232a1 > Cr-Commit-Position: refs/heads/master@{#312557} TBR=thakis@chromium.org,zork@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450771, 371125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
Created Revert of Disable -Wl,-z,defs on mipsel to suppress ffmpeg error
5 years, 10 months ago (2015-01-27 20:26:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873313007/1
5 years, 10 months ago (2015-01-27 20:26:49 UTC) #2
commit-bot: I haz the power
Failed to apply patch for build/config/compiler/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-01-27 20:27:34 UTC) #4
Nico
Already done in https://codereview.chromium.org/878603005
5 years, 10 months ago (2015-01-27 20:28:11 UTC) #6
jamesr
5 years, 10 months ago (2015-01-27 20:30:05 UTC) #7
Ah, cool.

Powered by Google App Engine
This is Rietveld 408576698