DescriptionRevert of Fix for the font files being maped multiple times (Fontconfig). (patchset #4 id:60001 of https://codereview.chromium.org/697383002/)
BUG=452227
Reason for revert:
Suspected for breaking security_OpenFDs on cros (http://crbug.com/452227):
01/26 13:31:23.658 ERROR|security_O:0147| Found unexpected fds in chrome type=renderer: set(['0500 /usr/share/fonts/croscore/Tinos-Regular.ttf', '0500 /usr/share/fonts/noto/NotoSans-Regular.ttc', '0500 /usr/share/fonts/noto/NotoSans-Bold.ttc'])
01/26 13:31:23.658 DEBUG|security_O:0138| Found pid 8280 for chrome
01/26 13:31:23.660 ERROR|security_O:0147| Found unexpected fds in chrome type=renderer: set(['0500 /usr/share/fonts/noto/NotoSans-Regular.ttc'])
Original issue's description:
> Fix for font files being mmaped multiple times (Fontconfig).
>
> Before this change, when there were a lot of font fallbacks happening on
> the web site, the fallback font was mmaped multiple times, reaching up to
> 200 times in the TC url: http://jsfiddle.net/p5pe81vs/, leading to OOMs
> and crashes for renderer process.
>
> This happens after the change introduced in
> https://codereview.chromium.org/307243002
>
> This CL keeps track of the mmaps for each font ID to avoid any further
> unnecessary IPC requests and mmaps for future requests of the same font
> ID that would result in new FD.
>
> BUG=430021
>
> NOPRESUBMIT=true
> brettw indicates this use of ScopedAllowIO is acceptable.
> Previous code eluded IO checks, this change makes the IO use find-able.
>
> Committed: https://crrev.com/78db5e535ef48c596223fe272572e5679fbb44fd
> Cr-Commit-Position: refs/heads/master@{#313102}
TBR=behdad@google.com,brettw@chromium.org,bungeman@chromium.org,derat@chromium.org,dominik.rottsches@intel.com,eae@chromium.org,jln@chromium.org,reed@chromium.org,jam@chromium.org,jochen@chromium.org,kolczyk@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=430021
Committed: https://crrev.com/2af12ff9d1f88963c3a3ff443002be21c78d74b3
Cr-Commit-Position: refs/heads/master@{#313171}
Patch Set 1 #
Created: 5 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 6 (1 generated)
|