Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 873033002: Cleanup: Remove unused blink::WebTextDirection parameter from Notification ctor. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 11 months ago
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused blink::WebTextDirection parameter from Notification ctor. BUG=None R=peter@chromium.org R=thestig@chromium.org Committed: https://crrev.com/0c485111ad919eafd0c5c86cdf2b565161d23e9e Cr-Commit-Position: refs/heads/master@{#313112}

Patch Set 1 #

Patch Set 2 : chromeos fixes #

Patch Set 3 : more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M chrome/browser/chromeos/policy/consumer_management_notifier.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/extension_welcome_notification_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/message_center_notifications_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/notification.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_conversion_helper_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_screenshot_grabber.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
PTAL. Is there a bug for this that I could fill in the CL description?
5 years, 11 months ago (2015-01-25 01:55:20 UTC) #1
Peter Beverloo
lgtm w/ title nit: s/Cleanuo/Cleanup/. Thanks! Please do run the try-bots since it's easy to ...
5 years, 11 months ago (2015-01-25 01:57:34 UTC) #2
tfarina
CL description typo fixed. +Lei for overall chrome/ approval!
5 years, 11 months ago (2015-01-25 02:04:54 UTC) #4
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-26 20:11:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873033002/40001
5 years, 11 months ago (2015-01-26 20:14:09 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-26 20:18:51 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:21:54 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0c485111ad919eafd0c5c86cdf2b565161d23e9e
Cr-Commit-Position: refs/heads/master@{#313112}

Powered by Google App Engine
This is Rietveld 408576698