Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: chrome/browser/notifications/message_center_notifications_browsertest.cc

Issue 873033002: Cleanup: Remove unused blink::WebTextDirection parameter from Notification ctor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <string> 6 #include <string>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 new_delegate->AddRef(); 119 new_delegate->AddRef();
120 } 120 }
121 121
122 message_center::RichNotificationData data; 122 message_center::RichNotificationData data;
123 123
124 return Notification(message_center::NOTIFICATION_TYPE_BASE_FORMAT, 124 return Notification(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
125 GURL("chrome-test://testing/"), 125 GURL("chrome-test://testing/"),
126 base::ASCIIToUTF16("title"), 126 base::ASCIIToUTF16("title"),
127 base::ASCIIToUTF16("message"), 127 base::ASCIIToUTF16("message"),
128 gfx::Image(), 128 gfx::Image(),
129 blink::WebTextDirectionDefault,
130 message_center::NotifierId( 129 message_center::NotifierId(
131 message_center::NotifierId::APPLICATION, 130 message_center::NotifierId::APPLICATION,
132 "extension_id"), 131 "extension_id"),
133 base::UTF8ToUTF16("chrome-test://testing/"), 132 base::UTF8ToUTF16("chrome-test://testing/"),
134 base::UTF8ToUTF16("REPLACE-ME"), 133 base::UTF8ToUTF16("REPLACE-ME"),
135 data, 134 data,
136 new_delegate); 135 new_delegate);
137 } 136 }
138 }; 137 };
139 138
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 manager()->Update(notification, profile()); 357 manager()->Update(notification, profile());
359 358
360 // Expect that the progress notification update is performed. 359 // Expect that the progress notification update is performed.
361 EXPECT_EQ(base::StringPrintf("update-%s", notification_id.c_str()), 360 EXPECT_EQ(base::StringPrintf("update-%s", notification_id.c_str()),
362 observer.log(notification_id)); 361 observer.log(notification_id));
363 362
364 delegate->Release(); 363 delegate->Release();
365 } 364 }
366 365
367 #endif // !defined(OS_MACOSX) 366 #endif // !defined(OS_MACOSX)
OLDNEW
« no previous file with comments | « chrome/browser/notifications/extension_welcome_notification_unittest.cc ('k') | chrome/browser/notifications/notification.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698