Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872993003: Distinguish between wired and wifi connections in the captive portal interstitial. (Closed)

Created:
5 years, 11 months ago by meacer
Modified:
5 years, 10 months ago
Reviewers:
felt
CC:
chromium-reviews, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Distinguish between wired and Wi-Fi connections in the captive portal interstitial. BUG=451272 Committed: https://crrev.com/ed335a35a7903ee1aea4b33491186eac810bfa21 Cr-Commit-Position: refs/heads/master@{#313434}

Patch Set 1 #

Patch Set 2 : Add tests #

Total comments: 2

Patch Set 3 : felt comment #

Patch Set 4 : Add comment about the accuracy of GetConnectionType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +16 lines, -4 lines 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page.cc View 1 2 3 6 chunks +27 lines, -5 lines 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc View 1 2 4 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
meacer
@felt: Can you PTAL? @mmenke: FYI.
5 years, 10 months ago (2015-01-27 22:54:25 UTC) #2
felt
lgtm % possible style nit https://codereview.chromium.org/872993003/diff/20001/chrome/browser/ssl/captive_portal_blocking_page.h File chrome/browser/ssl/captive_portal_blocking_page.h (right): https://codereview.chromium.org/872993003/diff/20001/chrome/browser/ssl/captive_portal_blocking_page.h#newcode40 chrome/browser/ssl/captive_portal_blocking_page.h:40: void set_wifi_connection_for_testing(bool is_wifi_connection) { ...
5 years, 10 months ago (2015-01-27 23:00:39 UTC) #3
meacer
https://codereview.chromium.org/872993003/diff/20001/chrome/browser/ssl/captive_portal_blocking_page.h File chrome/browser/ssl/captive_portal_blocking_page.h (right): https://codereview.chromium.org/872993003/diff/20001/chrome/browser/ssl/captive_portal_blocking_page.h#newcode40 chrome/browser/ssl/captive_portal_blocking_page.h:40: void set_wifi_connection_for_testing(bool is_wifi_connection) { On 2015/01/27 23:00:39, felt wrote: ...
5 years, 10 months ago (2015-01-28 00:40:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872993003/60001
5 years, 10 months ago (2015-01-28 00:40:51 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-28 04:14:47 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 04:16:09 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ed335a35a7903ee1aea4b33491186eac810bfa21
Cr-Commit-Position: refs/heads/master@{#313434}

Powered by Google App Engine
This is Rietveld 408576698