Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page.h

Issue 872993003: Distinguish between wired and wifi connections in the captive portal interstitial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment about the accuracy of GetConnectionType Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ssl/captive_portal_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/captive_portal_blocking_page.h
diff --git a/chrome/browser/ssl/captive_portal_blocking_page.h b/chrome/browser/ssl/captive_portal_blocking_page.h
index 18a4bab5613c48669735641cf375a9719d7a4c8f..ecdf073c3284b2ab6ddb94b97b17818d52d9e206 100644
--- a/chrome/browser/ssl/captive_portal_blocking_page.h
+++ b/chrome/browser/ssl/captive_portal_blocking_page.h
@@ -37,6 +37,10 @@ class CaptivePortalBlockingPage : public SecurityInterstitialPage {
// SecurityInterstitialPage method:
const void* GetTypeForTesting() const override;
+ void SetWiFiConnectionForTesting(bool is_wifi_connection) {
+ is_wifi_connection_ = is_wifi_connection;
+ }
+
protected:
// SecurityInterstitialPage methods:
void PopulateInterstitialStrings(
@@ -49,6 +53,8 @@ class CaptivePortalBlockingPage : public SecurityInterstitialPage {
private:
// URL of the login page, opened when the user clicks the "Connect" button.
GURL login_url_;
+ // True if on a Wi-Fi connection.
+ bool is_wifi_connection_;
base::Callback<void(bool)> callback_;
DISALLOW_COPY_AND_ASSIGN(CaptivePortalBlockingPage);
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ssl/captive_portal_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698