Update JNI generator for javap version 1.8.

Update JNI generator for javap version 1.8.

In javap 1.7 the signature line was prefixed with 'Signature: ', which in javap 1.8 has changed to 'descriptor: '.

This CL adds support for the new format, and adds a test to ensure that all parsers still work correctly.

Committed: https://crrev.com/f0286503313bc0214bd275cab9f3020511422415
Cr-Commit-Position: refs/heads/master@{#315329}

[Fredrik Öhrn, 2015-02-02 09:18:23]

ohrn@opera.com changed reviewers:
+ bulach@chromium.org, nyquist@chromium.org

[Fredrik Öhrn, 2015-02-02 09:21:43]

Tested with OpenJDK 1.8.0.

Reviewers: nyquist (owner) and bulach (updated this code for javap 1.7)

[nyquist, 2015-02-03 18:49:11]

lgtm, but could you update the CL description to describe what the change of the
output format between 1.7 and 1.8 this CL addresses?

Something along the lines (but feel free to use your own words):

In javap 1.7 the signature line was prefixed with 'Signature: ',
which in javap 1.8 has changed to 'descriptor: '. This CL
adds support for the new format, and adds a test to ensure that
all parsers still work correctly.

[Fredrik Öhrn, 2015-02-06 12:39:49]

On 2015/02/03 18:49:11, nyquist wrote:
> lgtm, but could you update the CL description to describe what the change of
the
> output format between 1.7 and 1.8 this CL addresses?
> 
> Something along the lines (but feel free to use your own words):
> 
> In javap 1.7 the signature line was prefixed with 'Signature: ',
> which in javap 1.8 has changed to 'descriptor: '. This CL
> adds support for the new format, and adds a test to ensure that
> all parsers still work correctly.

Sounds good to me. I'll take it verbatim.

[Fredrik Öhrn, 2015-02-06 12:40:04]

The CQ bit was checked by ohrn@opera.com

[commit-bot: I haz the power, 2015-02-06 12:40:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/872843004/1

[commit-bot: I haz the power, 2015-02-06 12:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 12:45:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fredrik Öhrn, 2015-02-06 13:25:11]

On 2015/02/06 12:45:40, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

I have no idea what the presubmit builder output is trying to tell me. So it
failed. But why?

If it's the 80 column warning that is treated as an error it would be nice if it
said so, and how to bypass it. Since it's a TC with verbatim output from javap
the line needs to stay the way it is.

[nyquist, 2015-02-06 17:46:35]

https://codereview.chromium.org/872843004/diff/1/base/android/jni_generator/j...
File base/android/jni_generator/jni_generator_tests.py (right):

https://codereview.chromium.org/872843004/diff/1/base/android/jni_generator/j...
base/android/jni_generator/jni_generator_tests.py:741: public class
java.util.HashSet<E> extends java.util.AbstractSet<E> implements
java.util.Set<E>, java.lang.Cloneable, java.io.Serializable {
Yeah, I think it's the line length.

From looking at java6 and java7 it seems like the stuff after java.util.HashSet
was just stripped previously.

The following does a quick javap -s for HashSet in both the Java 6 and Java 7
runtime using both the java6 and java7 javap implementation:
https://gist.github.com/curinir/5a6322003a6e86cff5e8

How about just using:
public class java.util.HashSet {

as the first line to keep it consistent (see content_javap6 and content_javap7
above)

[Fredrik Öhrn, 2015-02-09 16:20:50]

The CQ bit was checked by ohrn@opera.com

[commit-bot: I haz the power, 2015-02-09 16:22:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/872843004/20001

[commit-bot: I haz the power, 2015-02-09 17:24:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-09 17:25:06]

Patchset 2 (id:??) landed as
https://crrev.com/f0286503313bc0214bd275cab9f3020511422415
Cr-Commit-Position: refs/heads/master@{#315329}

[Fredrik Öhrn, 2015-02-09 17:30:24]

On 2015/02/06 17:46:35, nyquist wrote:
> How about just using:
> public class java.util.HashSet {
> 

That got it past the commit bot. Though, I think it's unfortunate that such
rigid rules get in the way of authentic test cases.