base/android/jni_generator/jni_generator.py - Issue 872843004: Update JNI generator for javap version 1.8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/jni_generator.py

Issue 872843004: Update JNI generator for javap version 1.8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Shorten line in test case Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/android/jni_generator/jni_generator.py

diff --git a/base/android/jni_generator/jni_generator.py b/base/android/jni_generator/jni_generator.py

index 53de36569b8b4c25a6a6935f81b3426f68a7a762..6e39c13d4b0631b90cc300fa26f8a324d8085283 100755

--- a/base/android/jni_generator/jni_generator.py

+++ b/base/android/jni_generator/jni_generator.py

@@ -209,7 +209,11 @@ class JniParams(object):

@staticmethod

def ParseJavaPSignature(signature_line):

prefix = 'Signature: '

- return '"%s"' % signature_line[signature_line.index(prefix) + len(prefix):]

+ index = signature_line.find(prefix)

+ if index == -1:

+ prefix = 'descriptor: '

+ index = signature_line.index(prefix)

+ return '"%s"' % signature_line[index + len(prefix):]

@staticmethod

def JavaToJni(param):

« no previous file with comments | « no previous file | base/android/jni_generator/jni_generator_tests.py » ('j') | no next file with comments »