Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 872793002: Update compiler warning flags (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org, Kimmo Kinnunen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update compiler warning flags - add -Wsign-compare, which has been catching useful issues for Kimmo; - add -Winit-self and -Wpointer-arith to Mac builds so everyone's using the same flags; - try try removing -Wno-uninitialized. This was only for the old 10.6 compiler that we have warnings set as non-errors now. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a07b297585f58c4cb4144e5625a31ce5d98c5e04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M gyp/common_conditions.gypi View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
5 years, 11 months ago (2015-01-23 14:47:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872793002/1
5 years, 11 months ago (2015-01-23 14:48:19 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-23 14:48:21 UTC) #5
bsalomon
lgtm
5 years, 11 months ago (2015-01-23 14:58:53 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 15:01:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a07b297585f58c4cb4144e5625a31ce5d98c5e04

Powered by Google App Engine
This is Rietveld 408576698