gyp/common_conditions.gypi - Issue 872793002: Update compiler warning flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/common_conditions.gypi

Issue 872793002: Update compiler warning flags (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gyp/common_conditions.gypi

diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi

index 0fbeb09c7840f2ba60d9f425d23146c9cd02935c..394cc6ccf2468647890c90a358a9b883b6574ebe 100644

--- a/gyp/common_conditions.gypi

+++ b/gyp/common_conditions.gypi

@@ -214,6 +214,7 @@

'-Wextra',

'-Winit-self',

'-Wpointer-arith',

+ '-Wsign-compare',

'-Wno-c++11-extensions',

'-Wno-unused-parameter',

@@ -376,6 +377,7 @@

'-Wextra',

'-Winit-self',

'-Wpointer-arith',

+ '-Wsign-compare',

'cflags_cc!': [

'-fno-rtti',

@@ -528,8 +530,11 @@

'WARNING_CFLAGS': [

'-Wall',

'-Wextra',

+ '-Winit-self',

+ '-Wpointer-arith',

+ '-Wsign-compare',

'-Wno-unused-parameter',

- '-Wno-uninitialized', # Disabled because we think GCC 4.2 is bad at this.

« no previous file with comments | « no previous file | no next file » | no next file with comments »