Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3212)

Unified Diff: chrome/browser/chromeos/login/error_screens_histogram_helper.h

Issue 872633008: Migrate (Network)ErrorScreen to ScreenContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/error_screens_histogram_helper.h
diff --git a/chrome/browser/chromeos/login/error_screens_histogram_helper.h b/chrome/browser/chromeos/login/error_screens_histogram_helper.h
index dd3a555398d291f10c0dd67a5ecac42b7157cf10..36ce337eae99fd8922541be739a0b0505fdbf952 100644
--- a/chrome/browser/chromeos/login/error_screens_histogram_helper.h
+++ b/chrome/browser/chromeos/login/error_screens_histogram_helper.h
@@ -5,7 +5,11 @@
#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_
#define CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_
-#include "chrome/browser/chromeos/login/screens/error_screen.h"
+#include <string>
+
+#include "base/gtest_prod_util.h"
+#include "base/time/time.h"
+#include "chrome/browser/chromeos/login/screens/network_error.h"
namespace chromeos {
FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowHideTime);
@@ -16,7 +20,7 @@ class ErrorScreensHistogramHelper {
public:
explicit ErrorScreensHistogramHelper(const std::string& screen_name);
void OnScreenShow();
- void OnErrorShow(ErrorScreen::ErrorState error);
+ void OnErrorShow(NetworkError::ErrorState error);
void OnErrorHide();
~ErrorScreensHistogramHelper();
@@ -27,12 +31,12 @@ class ErrorScreensHistogramHelper {
FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest,
TestShowShowHideTime);
// functions for testing.
- void OnErrorShowTime(ErrorScreen::ErrorState error, base::Time now);
+ void OnErrorShowTime(NetworkError::ErrorState error, base::Time now);
void OnErrorHideTime(base::Time now);
std::string screen_name_;
bool was_shown_;
- ErrorScreen::ErrorState last_error_shown_;
+ NetworkError::ErrorState last_error_shown_;
base::Time error_screen_start_time_;
base::TimeDelta time_on_error_screens_;
};

Powered by Google App Engine
This is Rietveld 408576698