chrome/browser/chromeos/login/error_screens_histogram_helper.h - Issue 872633008: Migrate (Network)ErrorScreen to ScreenContext

Side by Side Diff: chrome/browser/chromeos/login/error_screens_histogram_helper.h

Issue 872633008: Migrate (Network)ErrorScreen to ScreenContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc ('k') | chrome/browser/chromeos/login/error_screens_histogram_helper.cc » ('j') | chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_	5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_

6 #define CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_	6 #define CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_

7	7

8 #include "chrome/browser/chromeos/login/screens/error_screen.h"	8 #include <string>

	9

	10 #include "base/gtest_prod_util.h"

	11 #include "base/time/time.h"

	12 #include "chrome/browser/chromeos/login/screens/network_error.h"

9	13

10 namespace chromeos {	14 namespace chromeos {

11 FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowHideTime);	15 FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowHideTime);

12 FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowHideShowHideTime);	16 FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowHideShowHideTime);

13 FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowShowHideTime);	17 FORWARD_DECLARE_TEST(ErrorScreensHistogramHelperTest, TestShowShowHideTime);

14	18

15 class ErrorScreensHistogramHelper {	19 class ErrorScreensHistogramHelper {

16 public:	20 public:

17 explicit ErrorScreensHistogramHelper(const std::string& screen_name);	21 explicit ErrorScreensHistogramHelper(const std::string& screen_name);

18 void OnScreenShow();	22 void OnScreenShow();

19 void OnErrorShow(ErrorScreen::ErrorState error);	23 void OnErrorShow(NetworkError::ErrorState error);

20 void OnErrorHide();	24 void OnErrorHide();

21 ~ErrorScreensHistogramHelper();	25 ~ErrorScreensHistogramHelper();

22	26

23 private:	27 private:

24 FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest, TestShowHideTime);	28 FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest, TestShowHideTime);

25 FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest,	29 FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest,

26 TestShowHideShowHideTime);	30 TestShowHideShowHideTime);

27 FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest,	31 FRIEND_TEST_ALL_PREFIXES(ErrorScreensHistogramHelperTest,

28 TestShowShowHideTime);	32 TestShowShowHideTime);

29 // functions for testing.	33 // functions for testing.

30 void OnErrorShowTime(ErrorScreen::ErrorState error, base::Time now);	34 void OnErrorShowTime(NetworkError::ErrorState error, base::Time now);

31 void OnErrorHideTime(base::Time now);	35 void OnErrorHideTime(base::Time now);

32	36

33 std::string screen_name_;	37 std::string screen_name_;

34 bool was_shown_;	38 bool was_shown_;

35 ErrorScreen::ErrorState last_error_shown_;	39 NetworkError::ErrorState last_error_shown_;

36 base::Time error_screen_start_time_;	40 base::Time error_screen_start_time_;

37 base::TimeDelta time_on_error_screens_;	41 base::TimeDelta time_on_error_screens_;

38 };	42 };

39	43

40 } // namespace chromeos	44 } // namespace chromeos

41	45

42 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_	46 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_ERROR_SCREENS_HISTOGRAM_HELPER_H_

OLD	NEW