Chromium Code Reviews
Help | Chromium Project | Sign in
(52)

Issue 8726040: Added sudo to VBoxManage call, to fix permission denied error when building a VirtualBox image

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by Liam McLoughlin
Modified:
1 month, 3 weeks ago
Reviewers:
CC:
chromium-os-reviews_chromium.org
Base URL:
http://git.chromium.org/chromiumos/platform/crosutils.git@master
Visibility:
Public.

Description

Added sudo to VBoxManage call, to fix permission denied error when building a VirtualBox image BUG=None TEST=Run image_to_vm.sh to build a VirtualBox image for the x86-generic board, confirm image builds successfully Change-Id: I3ce9aac1eef6dfa695747e92e7d7e75ddd524027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M image_to_vm.sh View 1 chunk +1 line, -1 line 0 comments Download
Trybot results: Sign in to try more bots
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Liam McLoughlin
3 years, 6 months ago (2011-11-29 19:02:22 UTC) #1
jrbarnette
Hexxeh, I think this'll be fine, but for Chromium OS changes, we've switched to Gerrit, ...
3 years, 6 months ago (2011-11-30 16:42:47 UTC) #2
jrbarnette
3 years, 6 months ago (2011-11-30 16:49:13 UTC) #3
On 2011/11/30 16:42:47, jrbarnette wrote:
> Hexxeh,
> 
> I think this'll be fine, but for Chromium OS changes, we've switched to
Gerrit,
> so you'll need to resubmit with the new tool.  :-(
> 
> Some of what you'll need to do is documented here:
>   http://www.chromium.org/chromium-os/developer-guide/gerrit-guide
> 
> It *should* be as simple as this:
>  1) Get a Gerrit account as described at the link.
>  2) Upload the CL with a command like this:
>     cd src/scripts; repo upload .
> 
Note that the change will need to be on a branch all their
own that tracks cros/master as the upstream branch.

Also, 'repo upload' uploads each commit on the branch as a
separate CL.  That has two impacts:
  * If you need to make changes to upload a new patch,
    you'll need use this:
      git commit --amend
  * When you initially upload, the branch should contain
    just the change you want to make, and the commit
    comments need to reflect the final form.


> I'm afraid it's not as well documented as it ought to be.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be