Issue 872563002: Fix null crash in CheckTrailer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 872563002: Fix null crash in CheckTrailer. (Closed)

Created:
5 years, 11 months ago by Tom Sepez

Modified:
5 years, 11 months ago

Reviewers:
Bo Xu

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix null crash in CheckTrailer. We are making checks in the incorrect order. Also adds two test cases, one for the this crash, and another for the original issue that motivated the patch. Original Patch by Bo at https://codereview.chromium.org/866003003/ BUG=450871 R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/e0bbe4aac90e56950f28e322c3d6192c35af5ea0

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -4 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A	fpdfsdk/src/fpdf_dataavail_unittest.cpp	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	testing/embedder_test.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A	testing/resources/trailer_as_hexstring.in	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	testing/resources/trailer_as_hexstring.pdf	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
A	testing/resources/trailer_unterminated.in	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	testing/resources/trailer_unterminated.pdf	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 11 months ago (2015-01-23 23:05:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e0bbe4aac90e56950f28e322c3d6192c35af5ea0 (presubmit successful).