Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 866003003: Fix null crash in CheckTrailer. (Closed)

Created:
5 years, 11 months ago by Bo Xu
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com, rickyz (no longer on Chrome)
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix null crash in CheckTrailer. BUG=450871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Bo Xu
Ricky, please review this.
5 years, 11 months ago (2015-01-22 18:59:15 UTC) #2
Tom Sepez
LGTM (I reviewed the original patch and missed this entirely).
5 years, 11 months ago (2015-01-22 19:06:32 UTC) #4
Tom Sepez
On 2015/01/22 19:06:32, Tom Sepez wrote: > LGTM (I reviewed the original patch and missed ...
5 years, 11 months ago (2015-01-22 19:07:30 UTC) #5
Bo Xu
On 2015/01/22 19:06:32, Tom Sepez wrote: > LGTM (I reviewed the original patch and missed ...
5 years, 11 months ago (2015-01-22 19:08:19 UTC) #6
Bo Xu
On 2015/01/22 19:07:30, Tom Sepez wrote: > On 2015/01/22 19:06:32, Tom Sepez wrote: > > ...
5 years, 11 months ago (2015-01-22 19:09:47 UTC) #7
Tom Sepez
On 2015/01/22 19:09:47, Bo Xu wrote: > On 2015/01/22 19:07:30, Tom Sepez wrote: > > ...
5 years, 11 months ago (2015-01-22 19:11:06 UTC) #8
Tom Sepez
On 2015/01/22 19:11:06, Tom Sepez wrote: > On 2015/01/22 19:09:47, Bo Xu wrote: > > ...
5 years, 11 months ago (2015-01-23 02:18:18 UTC) #9
Bo Xu
5 years, 11 months ago (2015-01-24 20:23:00 UTC) #10
Close in regard to land of https://codereview.chromium.org/872563002/

Powered by Google App Engine
This is Rietveld 408576698