Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1990)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872543002: Take budgeted param when snapping new image. (Closed)

Created:
5 years, 11 months ago by bsalomon
Modified:
5 years, 11 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@budgeted
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Take budgeted param when snapping new image. Committed: https://skia.googlesource.com/skia/+/eaaaf0b16c4e55ff8a48c5ac1ed623a6ba469053

Patch Set 1 #

Patch Set 2 : update, add test #

Patch Set 3 : update #

Total comments: 2

Patch Set 4 : Address comment and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -65 lines) Patch
M gyp/gpu.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkSurface.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/image/SkImagePriv.h View 1 2 2 chunks +9 lines, -1 line 0 comments Download
A src/image/SkImage_Gpu.h View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 2 3 2 chunks +10 lines, -38 lines 0 comments Download
M src/image/SkSurface.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/image/SkSurface_Base.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/image/SkSurface_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 2 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
5 years, 11 months ago (2015-01-23 02:33:24 UTC) #2
reed1
bleh lgtm
5 years, 11 months ago (2015-01-23 15:03:11 UTC) #3
robertphillips
https://codereview.chromium.org/872543002/diff/40001/src/image/SkImage_Gpu.cpp File src/image/SkImage_Gpu.cpp (right): https://codereview.chromium.org/872543002/diff/40001/src/image/SkImage_Gpu.cpp#newcode58 src/image/SkImage_Gpu.cpp:58: overlength
5 years, 11 months ago (2015-01-23 15:09:28 UTC) #4
bsalomon
https://codereview.chromium.org/872543002/diff/40001/src/image/SkImage_Gpu.cpp File src/image/SkImage_Gpu.cpp (right): https://codereview.chromium.org/872543002/diff/40001/src/image/SkImage_Gpu.cpp#newcode58 src/image/SkImage_Gpu.cpp:58: On 2015/01/23 15:09:28, robertphillips wrote: > overlength Done.
5 years, 11 months ago (2015-01-23 15:32:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872543002/60001
5 years, 11 months ago (2015-01-23 15:56:50 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 16:08:08 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/eaaaf0b16c4e55ff8a48c5ac1ed623a6ba469053

Powered by Google App Engine
This is Rietveld 408576698