Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4647)

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 872433003: Remove omnibox watcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index 4870ab39fbf993f8e4898dbf2664e9fb2403f876..e4e1bb27c802aa780c4e85b72b79c57926f57560 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -364,9 +364,6 @@ message ClientIncidentReport {
optional ClientDownloadRequest.SignatureInfo signature = 5;
optional ClientDownloadRequest.ImageHeaders image_headers = 6;
}
- message OmniboxInteractionIncident {
- optional string origin = 1;
- }
message VariationsSeedSignatureIncident {
optional string variations_seed_signature = 1;
}
@@ -374,7 +371,7 @@ message ClientIncidentReport {
optional TrackedPreferenceIncident tracked_preference = 2;
optional BinaryIntegrityIncident binary_integrity = 3;
optional BlacklistLoadIncident blacklist_load = 4;
- optional OmniboxInteractionIncident omnibox_interaction = 5;
+ // Note: skip tag 5 because it was previously used.
Mark P 2015/01/22 22:36:59 Isn't it better practice to leave the message and
Mark P 2015/01/22 22:38:18 Also, once we settle on the proto changes or lack
grt (UTC plus 2) 2015/01/23 16:46:32 That may be good practice where there's still exis
grt (UTC plus 2) 2015/01/23 16:46:32 We'll keep the message on the back-end. Happy to d
Mark P 2015/01/23 16:55:03 Given that you're keeping the message on the backe
optional VariationsSeedSignatureIncident variations_seed_signature = 6;
}
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698