Remove omnibox watcher.

chrome/common/safe_browsing/csd.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Client side phishing and malware detection request and response
 // protocol buffers.  Those protocol messages should be kept in sync
 // with the server implementation.
 //
 // If you want to change this protocol definition or you have questions
 // regarding its format please contact chrome-anti-phishing@googlegroups.com.
@@ skipping 346 matching lines @@
       optional ClientDownloadRequest.SignatureInfo signature = 2;
     }
     message BlacklistLoadIncident {
       optional string path = 1;
       optional ClientDownloadRequest.Digests digest = 2;
       optional string version = 3;
       optional bool blacklist_initialized = 4;
       optional ClientDownloadRequest.SignatureInfo signature = 5;
       optional ClientDownloadRequest.ImageHeaders image_headers = 6;
     }
-    message OmniboxInteractionIncident {
-      optional string origin = 1;
-    }
     message VariationsSeedSignatureIncident {
       optional string variations_seed_signature = 1;
     }
     optional int64 incident_time_msec = 1;
     optional TrackedPreferenceIncident tracked_preference = 2;
     optional BinaryIntegrityIncident binary_integrity = 3;
     optional BlacklistLoadIncident blacklist_load = 4;
-    optional OmniboxInteractionIncident omnibox_interaction = 5;
+    // Note: skip tag 5 because it was previously used.

[Mark P, 2015/01/22 22:36:59]

Isn't it better practice to leave the message and this declaration and mark it
as deprecated = true?

[Mark P, 2015/01/22 22:38:18]

Also, once we settle on the proto changes or lack thereof, shouldn't we update
the server first?

[grt (UTC plus 2), 2015/01/23 16:46:32]

That may be good practice where there's still existing code, but in this case
there will be no Chrome code producing or consuming this particular message. May
as well not carry the weight in the generated code.

[grt (UTC plus 2), 2015/01/23 16:46:32]

We'll keep the message on the back-end. Happy to discuss off-CL.

[Mark P, 2015/01/23 16:55:03]

Given that you're keeping the message on the backend, I think this policy of
removing the deprecated message on the frontend sounds fine.

     optional VariationsSeedSignatureIncident variations_seed_signature = 6;
   }
 
   repeated IncidentData incident = 1;
 
   message DownloadDetails {
     optional bytes token = 1;
     optional ClientDownloadRequest download = 2;
     optional int64 download_time_msec = 3;
     optional int64 open_time_msec = 4;
@@ skipping 72 matching lines @@
   message EnvironmentRequest { optional int32 dll_index = 1; }
 
   repeated EnvironmentRequest environment_requests = 3;
 }
 
 message DownloadMetadata {
   optional uint32 download_id = 1;
 
   optional ClientIncidentReport.DownloadDetails download = 2;
 }